improve error handler

This commit is contained in:
SrGooglo 2023-02-24 14:43:54 +00:00
parent b39d250bcb
commit d5e8d5e498

View File

@ -77,7 +77,10 @@ export default async (payload) => {
} }
} }
let failed = [] const processedFiles = []
const failedFiles = []
let queuePromieses = []
// check directories exist // check directories exist
if (!fs.existsSync(params.cacheUploadDir)) { if (!fs.existsSync(params.cacheUploadDir)) {
@ -99,10 +102,10 @@ export default async (payload) => {
filter: (stream) => { filter: (stream) => {
// check if is allowed mime type // check if is allowed mime type
if (!params.acceptedMimeTypes.includes(stream.mimetype)) { if (!params.acceptedMimeTypes.includes(stream.mimetype)) {
failed.push({ failedFiles.push({
fileName: file.originalFilename, fileName: stream.originalFilename,
mimetype: file.mimetype, mimetype: stream.mimetype,
error: "mimetype not allowed", error: "File type not allowed",
}) })
return false return false
@ -113,11 +116,6 @@ export default async (payload) => {
}) })
const results = await new Promise((resolve, reject) => { const results = await new Promise((resolve, reject) => {
const processedFiles = []
const failedFiles = []
let queuePromieses = []
// create a new thread for each file // create a new thread for each file
form.parse(req, async (err, fields, data) => { form.parse(req, async (err, fields, data) => {
if (err) { if (err) {
@ -205,7 +203,11 @@ export default async (payload) => {
async (fn) => { async (fn) => {
const result = await fn().catch((err) => { const result = await fn().catch((err) => {
console.error(err) console.error(err)
failedFiles.push(err)
// FIXME: add fileNames
failedFiles.push({
error: err.message,
})
return null return null
}) })
@ -214,7 +216,7 @@ export default async (payload) => {
processedFiles.push(result) processedFiles.push(result)
} }
}, },
{ concurrency: 5 } { concurrency: 10 }
) )
return resolve({ return resolve({