RageStudio/comty
1
0
Fork 0
mirror of https://github.com/ragestudio/comty.git synced 2025-06-10 02:54:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix depends validation & unsubscribe update events for unmounted items

Browse Source
This commit is contained in:
srgooglo 2022-05-31 00:51:04 +02:00
parent 4f19250d07
commit aa84b5d006
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/app/src/components/Settings/index.jsx
View File

@ -100,6 +100,15 @@ const SettingItem = (props) => {
} }
} }
const onUnmount = () => {
// unsubscribe eventBus events
if (typeof item.dependsOn === "object") {
for (let key in item.dependsOn) {
window.app.eventBus.off(`setting.update.${key}`, onUpdateItem)
}
}
}
const checkDependsValidation = () => { const checkDependsValidation = () => {
return !Boolean(Object.keys(item.dependsOn).every((key) => { return !Boolean(Object.keys(item.dependsOn).every((key) => {
const storagedValue = window.app.settings.get(key) const storagedValue = window.app.settings.get(key)
@ -133,7 +142,7 @@ const SettingItem = (props) => {
}) })
// by default check depends validation // by default check depends validation
item.props.disabled = checkDependsValidation() setDisabled(checkDependsValidation())
} }
if (typeof item.listenUpdateValue === "string") { if (typeof item.listenUpdateValue === "string") {
@ -152,6 +161,8 @@ const SettingItem = (props) => {
React.useEffect(() => { React.useEffect(() => {
settingInitialization() settingInitialization()
return onUnmount
}, []) }, [])
if (typeof SettingComponent === "string") { if (typeof SettingComponent === "string") {