From 01339a175fb10255788e4814291e8ff32ea4ac79 Mon Sep 17 00:00:00 2001
From: srgooglo <srgooglo@ragestudio.net>
Date: Fri, 9 Sep 2022 20:38:27 +0200
Subject: [PATCH] fix endpoint

---
 .../PostsController/methods/deletePost.js     | 22 ++++++-------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/packages/server/src/controllers/PostsController/methods/deletePost.js b/packages/server/src/controllers/PostsController/methods/deletePost.js
index 261e367c..bf8ac426 100644
--- a/packages/server/src/controllers/PostsController/methods/deletePost.js
+++ b/packages/server/src/controllers/PostsController/methods/deletePost.js
@@ -1,19 +1,5 @@
 import { Post, User } from "../../../models"
 
-async function hasAdmin(user_id) {
-    if (!user_id) {
-        return false
-    }
-
-    const userData = await User.findById(user_id)
-
-    if (!userData) {
-        return false
-    }
-
-    return userData.roles.includes("admin")
-}
-
 export default async (payload) => {
     const { post_id, by_user_id } = payload
 
@@ -27,7 +13,13 @@ export default async (payload) => {
         throw new Error("Post not found")
     }
 
-    const hasAdmin = await hasAdmin(by_user_id)
+    const userData = await User.findById(by_user_id)
+
+    if (!userData) {
+        throw new Error("User not found")
+    }
+
+    const hasAdmin = userData.roles.includes("admin")
 
     // check if user is the owner of the post
     if (post.user_id !== by_user_id && !hasAdmin) {